From 0754f1b53730ec3dd8eec602da09c26a894da264 Mon Sep 17 00:00:00 2001 From: bluwy Date: Wed, 12 Oct 2022 22:40:31 +0800 Subject: [PATCH 1/2] fix(config): partial deno support --- packages/vite/src/node/config.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/packages/vite/src/node/config.ts b/packages/vite/src/node/config.ts index dd0feee665ae34..05b453d48edb64 100644 --- a/packages/vite/src/node/config.ts +++ b/packages/vite/src/node/config.ts @@ -986,6 +986,9 @@ async function bundleConfigFile( build.onResolve({ filter: /.*/ }, ({ path: id, importer, kind }) => { // externalize bare imports if (id[0] !== '.' && !path.isAbsolute(id) && !isBuiltin(id)) { + if (id.startsWith('npm:')) { + return { external: true } + } let idFsPath = tryNodeResolve(id, importer, options, false)?.id if (idFsPath && (isESM || kind === 'dynamic-import')) { idFsPath = pathToFileURL(idFsPath).href From 014bb0ed4333177a7c34e5eb9365a892916121cb Mon Sep 17 00:00:00 2001 From: bluwy Date: Wed, 12 Oct 2022 22:47:39 +0800 Subject: [PATCH 2/2] docs: add docs --- packages/vite/src/node/config.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/vite/src/node/config.ts b/packages/vite/src/node/config.ts index 05b453d48edb64..9467cad2c1f7df 100644 --- a/packages/vite/src/node/config.ts +++ b/packages/vite/src/node/config.ts @@ -986,6 +986,7 @@ async function bundleConfigFile( build.onResolve({ filter: /.*/ }, ({ path: id, importer, kind }) => { // externalize bare imports if (id[0] !== '.' && !path.isAbsolute(id) && !isBuiltin(id)) { + // partial deno support as `npm:` does not work in `tryNodeResolve` if (id.startsWith('npm:')) { return { external: true } }