feat(ssr): warn if cant analyze dynamic import #9738
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If SSR contains a dynamic import that can't be analyzed, warn about it. (similar to client)
Also only warn if the file we're analyzing is not in
node_modules
, since the user likely can't do anything except patching. (Could hide potential problems but maybe the cases are rare 🤔 )Ref withastro/astro#3373 (comment)
Additional context
Happy to discuss each changes, maybe I'm missing some important aspects.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).