Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: narrow down rollup version #9637

Merged
merged 2 commits into from
Aug 11, 2022
Merged

Conversation

patak-dev
Copy link
Member

Description

See @antfu comment for context:

Used a more complex range to avoid over-constraining in a patch.

In general, I think we should start to lock rollup version to a minor, and only update it in our minors moving forward.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

sapphi-red
sapphi-red previously approved these changes Aug 11, 2022
@patak-dev
Copy link
Member Author

Merging as we discussed it with @antfu and @sapphi-red, full run of vite-ecosystem-ci was successful

@patak-dev patak-dev merged commit fcf4d98 into main Aug 11, 2022
@patak-dev patak-dev deleted the chore/narrow-down-rollup-version branch August 11, 2022 18:50
@patak-dev patak-dev mentioned this pull request Aug 12, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants