Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix incomplete comment #9466

Merged
merged 2 commits into from
Jul 31, 2022
Merged

docs: fix incomplete comment #9466

merged 2 commits into from
Jul 31, 2022

Conversation

kidonng
Copy link
Contributor

@kidonng kidonng commented Jul 31, 2022

Description

It seems like this comment should be the same as the following:

/**
* The resolved urls Vite prints on the CLI. null in middleware mode or
* before `server.listen` is called.
*
* @experimental
*/
resolvedUrls: ResolvedServerUrls | null

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy enabled auto-merge (squash) July 31, 2022 12:42
@bluwy
Copy link
Member

bluwy commented Jul 31, 2022

Thanks for the fix!

@bluwy bluwy merged commit 5169c51 into vitejs:main Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants