Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create-vite): remove import from public #9074

Merged
merged 1 commit into from
Jul 13, 2022
Merged

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Jul 13, 2022

Description

We can't import vite.svg from the public folder, even though it works, as the docs don't guarantee it.

Additional context

We should probably report a warning.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@netlify
Copy link

netlify bot commented Jul 13, 2022

Deploy Preview for vite-docs-main canceled.

Name Link
🔨 Latest commit 9a78464
🔍 Latest deploy log https://app.netlify.com/sites/vite-docs-main/deploys/62cebfe61d5e2e0008ea34a8

@patak-dev patak-dev merged commit 880f560 into main Jul 13, 2022
@patak-dev patak-dev deleted the fix-create-vite-import branch July 13, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants