Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ssrBuild is optional, avoid breaking VitePress #8912

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

patak-dev
Copy link
Member

Description

Follow up on:

It is breaking VitePress. The PR makes it optional, and experimental, I think more discussion is needed around DX of this flag when we have CLIs based on Vite that don't have separate commands for SSR build.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@netlify
Copy link

netlify bot commented Jul 4, 2022

Deploy Preview for vite-docs-main ready!

Name Link
🔨 Latest commit de40592
🔍 Latest deploy log https://app.netlify.com/sites/vite-docs-main/deploys/62c2aa14f88c100009ea55eb
😎 Deploy Preview https://deploy-preview-8912--vite-docs-main.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@patak-dev patak-dev requested a review from bluwy July 4, 2022 08:51
@patak-dev patak-dev merged commit 722f514 into main Jul 4, 2022
@patak-dev patak-dev deleted the fix/optional-ssrbuild-flag branch July 4, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants