Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert #5902, fix #8243 #8654

Merged
merged 2 commits into from
Jun 19, 2022
Merged

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Jun 19, 2022

Description

See #5902 (comment)

fixes #8243
reopens #5901

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added feat: css p3-minor-bug An edge case that only affects very specific usage (priority) regression The issue only appears after a new release labels Jun 19, 2022
'rgb(255, 0, 0)',
true
)
await untilUpdated(() => getColor('#dynamic-css'), 'red', true)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test was failing with #5902 when cssCodeSplit=true. (cssCodeSplit is set to false in vite.config.js)

@patak-dev
Copy link
Member

@shir0u we need this revert to avoid regressions in v3. PR welcome to fix #5901 taking into account the issues raised by Sapphi

@patak-dev patak-dev merged commit 1b820da into vitejs:main Jun 19, 2022
@sapphi-red sapphi-red deleted the fix/revert-5902 branch June 19, 2022 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: css p3-minor-bug An edge case that only affects very specific usage (priority) regression The issue only appears after a new release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS not included in lazy-loading legacy files in Vite 3.0.0-alpha.1
2 participants