Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup now that we've dropped Node 12 #8239

Merged
merged 4 commits into from
May 23, 2022

Conversation

benmccann
Copy link
Collaborator

Description

Drop Node 12 code

Additional context

Discovered here: https://github.com/vitejs/vite/pull/8235/files#r877715524


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Shinigami92
Shinigami92 previously approved these changes May 20, 2022
@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label May 20, 2022
sapphi-red
sapphi-red previously approved these changes May 20, 2022
@patak-dev
Copy link
Member

Awesome, let's merge this one in a few days, after we do another 2.9 patch.

ydcjeff
ydcjeff previously approved these changes May 20, 2022
@patak-dev patak-dev dismissed stale reviews from ydcjeff, sapphi-red, and Shinigami92 via 6a192be May 23, 2022 18:00
@patak-dev patak-dev merged commit 29659a0 into vitejs:main May 23, 2022
@benmccann benmccann deleted the node-12-cleanup branch May 23, 2022 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants