Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rewrite CJS specific funcs/vars in plugins #8227

Merged
merged 1 commit into from
May 19, 2022

Conversation

sapphi-red
Copy link
Member

Description

After #8139, plugins were not working when it is imported as ESM (for example, when type='module' is set in package.json) reported at #8139 (comment).

This PR rewrites require/__dirname to use createRequire.
Another way to solve this is to set rollup.cjsBridge in build.config.ts to true.

Should p4-important be used for alpha versions too?

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added plugin: vue-jsx plugin: legacy p4-important Violate documented behavior or significantly improves performance (priority) regression The issue only appears after a new release labels May 19, 2022
@antfu antfu merged commit 9baa70b into vitejs:main May 19, 2022
@sapphi-red sapphi-red deleted the fix/mjs-plugins branch May 19, 2022 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p4-important Violate documented behavior or significantly improves performance (priority) plugin: legacy regression The issue only appears after a new release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants