server.hmr = false should disable server ping

[jcushman]

Describe the bug

When HMR is disabled with server.hmr = false, client.ts still opens a websocket to the server, and then runs await fetch(`${base}__vite_ping`) once per second if the socket is closed.

This is a problem in backend integration settings (e.g. Django) because the default value for ${base} points to the backend server rather than the vite server, and there is no way to configure the value with hmr disabled.

This means if the socket is closed, Vite ends up pinging the backend server until refresh, with no way to configure what url is being pinged. This ends up polluting the backend dev server log with continual 404s and interfering with development.

There are some previous related bugs about disabling HMR and/or server ping: #1729 #1989 #5228 #5763. I'm filing this one separately to document the issue that server.hmr = false ends up pinging an unrelated server in backend integrations and can't be configured. Having server.hmr = false disable ping seems like a promising fix.

Reproduction

na

System Info

na

Used Package Manager

npm

Logs

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/core instead.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[sapphi-red]

Is this a duplicate of #2345?

[jcushman]

I missed that one! It's not quite a dupe, but it would help: the fix for that bug (proposed in the #6819 PR) would still leave vite pinging an unconfigurable hmr url with server.hmr = false, but it would ping the vite server instead of the backend server, so not cause as much of a problem.

This bug strikes me as still valid in principle: if the way to disable hmr is server.hmr = false, then setting that should disable things like hmr pings that are configured by server.hmr.server, server.hmr.port etc. Disabling hmr is mutually incompatible with configuring hmr in vite's config language, so it should turn off things configured under server.hmr, or there should be another way to disable hmr.

I'm not sure there's another bug that exactly covers this, but there's a bunch of bugs all in this general cluster, so I'm fine with closing this if it's easier to track elsewhere.

[sapphi-red]

Do you want to disable pings to vite server? If so, why do you want to do that?
I don't think there is a situation which someone needs to disable pings to vite server.

[masterkain]

#8133

[sapphi-red]

Closing as the original issue is solved by #6819.