Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(create-vite): add isolatedModules #7697

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

sapphi-red
Copy link
Member

Description

add isolatedModules to create-vite (lit-ts, svelte-ts, vanilla-ts).

It is recommended in docs.

related: #7304

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@@ -13,7 +13,8 @@
* of JS in `.svelte` files.
*/
"allowJs": true,
"checkJs": true
"checkJs": true,
"isolatedModules": true
Copy link
Member Author

@sapphi-red sapphi-red Apr 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is defined here so this line is not needed actually. But I put this line to ensure even if @tsconfig/svelte/tsconfig.json changes. (I don't have a strong opinion here.)
https://github.com/tsconfig/bases/blob/27f9097a02f960e351d69bca8dd4c7581d70e1b6/bases/svelte.json#L19

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to make it explicit too 👍

@bluwy bluwy added the p1-chore Doesn't change code behavior (priority) label Apr 12, 2022
@patak-dev patak-dev merged commit 8f28350 into vitejs:main Apr 12, 2022
@sapphi-red sapphi-red deleted the create-vite-isolated-modules branch April 12, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants