fix(plugin-react): restore-jsx bug when component name is lowercase #6110
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in JSX restoration of the React plugin:
React.createElement(aaa)
is being transformed into<aaa />
which actually corresponds toReact.createElement("aaa")
. See the added test case. Of course I wouldn't give my React components lowercase names but minifiers are not always as considerate :)Additional context
This fix opts out of the transform if the tag name doesn't start with an uppercase letter. I'm not exactly sure it's the best fix. But the ideal fix (renaming the identifier into something that starts with an uppercase letter) would require much more work and greatly complicate the JSX restoration plugin.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).