-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jest CI issues #3106
Comments
Why would that be better? Do you know if there are performance implications? |
Just something to try out, because it's incredibly hard to isolate why the teardown seems to happen before the test finishes running. I don't think opening a new window per spec file has much of a performance penalty, but we'd have to check. You could help with the debugging by running:
You can also enable https://github.com/vitejs/vite/blob/ffa03ad/scripts/jestGlobalSetup.js#L9-L14 |
Closing as we've migrated to Vitest #8076 |
Creating this to keep track of the problems.
Prior related PRs: #3056, #3096, #3097, #3098
I still get an error sometimes, while running
yarn test
(i.e. in concurrent mode). This doesn't fail withyarn test-serve --runInBand
oryarn test-build --runInBand
The root cause still seems to be that the teardown is initiated before
ssr-vue.spec.ts
runs.I wonder if a better strategy would be to use one page per test suite, as described here: https://playwright.dev/docs/test-runners#jest--jasmine
However, when changing the setup to match that, many tests fail (on assertions), possibly because they rely on the page being changed by previous tests in the same test suite (spec file).
The text was updated successfully, but these errors were encountered: