fix: don't watch SPA fallback paths #14953
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the CI fail in vuejs/vitepress#3200.
https://discord.com/channels/804011606160703521/831456449632534538/1172931790554546368
The reason why it was failing with
ELOOP: too many symbolic links encountered, stat '/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/gems/mechanize-2.9.1/mechanize-2.9.1'
since beta.17 is becauseensureWatchedFile(watcher, id, root)
after no plugin'sload
hook handled that id/home
was passed to that because accessing/home
goes through the plugin pipeline (vite/packages/vite/src/node/server/transformRequest.ts
Lines 201 to 205 in b42a228
ensureWatchedFile
hasfs.existsSync(file)
, but/home
istrue
even though that is not a fileI moved the
ensureWatchedFile
afterif (options.html && !id.endsWith('.html'))
. Instead, I can move some code fromloadAndTransform
to the plugin container, but I think it's safer to avoid that.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).