perf(define): create simple regex for checks #14788
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An optimization I intentionally left out (so it's easier to review) in #11151 is to optimize the created regex. Since we're not doing any replacement anymore, we don't need a complex regex for correctness.
We only need a simple regex to check the chances of replacing, and through some quick tests, I found the complex regex vs this simple regex can bring up to 6x faster
regex.test()
calls (~200ms vs ~30ms)Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).