[5.0 beta 13] Issue with define replacement using esbuild

[smeng9]

Describe the bug

I am an author of npm package and in my published package it contains expression like import.meta.env.VITE_API_ORIGIN so my downstream user can use environment variable to override it. I publish my package using vite and I use the define: {"import.meta.env.VITE_API_ORIGIN": "import.meta.env.VITE_API_ORIGIN"} in the vite.config.ts to preserve this expression during transpilation. This works well in v4 and v5 beta until the breaking change in #11151 and I have not found a workaround yet. I have tried using @rollup/plugin-replace but also no luck there.

Reproduction

https://stackblitz.com/edit/vitejs-vite-yht5de?file=vite.config.ts,src%2Findex.ts,package.json,dist%2Findex.js&terminal=dev

Steps to reproduce

Run yarn followed by yarn build

Then go to the dist/index.js file

When using vite 4.5.0, the output is

const t = import.meta.env.VITE_API_ORIGIN;
export {
  t as myurl
};

My users who import this package can use a .env file to change this variable.

When using vite 5.0.0-beta.13, the output becomes

var e = { BASE_URL: "/", MODE: "production", DEV: !1, PROD: !0, SSR: !1 };
const t = e.VITE_API_ORIGIN;
export {
  t as myurl
};

The difference here is import.meta.env expression disappears and my downstream users can no longer use environment variable to perform replacement in the library.

System Info

System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 18.18.0 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 9.4.2 - /usr/local/bin/npm
    pnpm: 8.9.2 - /usr/local/bin/pnpm
  npmPackages:
    @vitejs/plugin-react: ^4.1.0 => 4.1.0 
    vite: ^5.0.0-beta.13 => 5.0.0-beta.13

Used Package Manager

yarn

Logs

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[stackblitz]

Start a new pull request in StackBlitz Codeflow.

• vitejs-vite-yht5de (Open reproduction)

[bluwy]

Thanks for the report. It seems like an optimization I made here:

vite/packages/vite/src/node/plugins/define.ts

Lines 52 to 60 in d5d96e7

	// user can define keys with the same values to declare that some keys
	// should not be replaced. in this case, we delete references of the key
	// so they aren't replaced in the first place.
	const val = config.define[key]
	if (key === val) {
	delete processNodeEnv[key]
	delete importMetaKeys[key]
	continue
	}

Was actually causing issues as the unreplaced import.meta.env.VITE_API_ORIGIN identifier was still getting replaced by the import.meta.env object. I think removing that should work.