TypeScript: Vite relies on "dom" lib

[sheremet-va]

Describe the bug

When using vite with TypeScript that doesn't reference dom lib, type checking gives an error:

node_modules/.pnpm/vite@4.4.9_@types+node@20.8.0/node_modules/vite/types/customEvent.d.ts:26:14 - error TS2304: Cannot find name 'WebSocket'.

26   webSocket: WebSocket
                ~~~~~~~~~

node_modules/.pnpm/vite@4.4.9_@types+node@20.8.0/node_modules/vite/types/importGlob.d.ts:36:11 - error TS2304: Cannot find name 'Worker'.

36   worker: Worker
             ~~~~~~

This happens because vite exports type GeneralImportGlobOptions from its vite entry:

vite/packages/vite/src/node/plugins/importMetaGlob.ts

Line 21 in 91a18c2

import type { GeneralImportGlobOptions } from 'types/importGlob'

This is a problem because types/importGlob references a global Worker variable that doesn't exist in @types/node (which is an optional dependency of Vite). WebSocket has the same problem. Ideally, we should have a separate shared file from which these options can be imported. Or they can also just be inlined in the vite entrypoint.

Reproduction

https://stackblitz.com/edit/node-rygrfb?file=tsconfig.json,index.ts,package.json

Steps to reproduce

pnpm run test

System Info

Stackblitz

Used Package Manager

npm

Logs

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[bluwy]

We have another report for this at #9813. Closing in favour of it.

[sheremet-va]

We have another report for this at #9813. Closing in favour of it.

Thank you! GitHub search is quite bad 🙏🏻