Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dynamic import vars ignored warning #14006

Merged
merged 2 commits into from
Aug 7, 2023
Merged

Conversation

patak-dev
Copy link
Member

@patak-dev patak-dev commented Aug 1, 2023

Description

When building the reproduction in #5051, we get

6:26:20 PM [vite] warning: Module "https" has been externalized for browser compatibility, imported by "/Users/patak/test/dynamic-vite-ignored/main.js". See http://vitejs.dev/guide/troubleshooting.html#module-externalized-for-browser-compatibility for more details.

This PR respect /*@vite-ignore*/ on the dynamic import var plugin to avoid this issue.

The PR doesn't fix, #5051


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@stackblitz
Copy link

stackblitz bot commented Aug 1, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@bluwy bluwy merged commit 4479431 into main Aug 7, 2023
20 checks passed
@bluwy bluwy deleted the fix/dynamic-import-vars-ignored branch August 7, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants