Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly clean up optimization temp folder #12237

Merged
merged 6 commits into from
Mar 1, 2023

Conversation

patak-dev
Copy link
Member

Description

Use the new esbuild context.cancel() method to stop optimization runs. This is a continuation of:

Before this PR, there may be a path where the deps_temp folder wasn't properly cleaned up.

After #12225 and this PR are merged, I'll explore using unique names for the temp folders.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@stackblitz
Copy link

stackblitz bot commented Feb 28, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

benmccann
benmccann previously approved these changes Feb 28, 2023
@patak-dev
Copy link
Member Author

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

vite-ecosystem-ci bot commented Feb 28, 2023

📝 Ran ecosystem CI: Open

suite result
astro ✅ success
histoire ❌ failure
iles ✅ success
ladle ✅ success
laravel ✅ success
marko ✅ success
nuxt-framework ✅ success
previewjs ✅ success
qwik ✅ success
rakkas ✅ success
sveltekit ✅ success
vite-plugin-ssr ✅ success
vite-plugin-react ✅ success
vite-plugin-react-pages ❌ failure
vite-plugin-react-swc ✅ success
vite-plugin-svelte ✅ success
vite-plugin-vue ❌ failure
vite-setup-catalogue ✅ success
vitepress ✅ success
vitest ✅ success
windicss ✅ success

@patak-dev
Copy link
Member Author

I'm seeing flakiness on this PR, but I think it is across the board. I have seen several fails on main these past two days. @bluwy @sapphi-red maybe you could check this one out just in case too.

patak-dev and others added 3 commits March 1, 2023 09:56
Co-authored-by: 翠 / green <green@sapphi.red>
Co-authored-by: 翠 / green <green@sapphi.red>
@patak-dev patak-dev merged commit fbbf8fe into main Mar 1, 2023
@patak-dev patak-dev deleted the fix/dedupe-optimizer-temp-dirs branch March 1, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants