fix(hmr): don't mutate module graph when collecting modules (#16302)

sapphi-red · web-flow · commit dfffea1f4363 · 2024-03-29T05:51:38.000+01:00
diff --git a/packages/vite/src/node/server/hmr.ts b/packages/vite/src/node/server/hmr.ts
@@ -162,7 +162,7 @@ export async function handleHMRUpdate(
     return
   }
 
-  const mods = moduleGraph.getModulesByFile(file) || new Set()
+  const mods = new Set(moduleGraph.getModulesByFile(file))
   if (type === 'create' || type === 'delete') {
     for (const mod of getAffectedGlobModules(file, server)) {
       mods.add(mod)

Original file line number	Diff line number	Diff line change
`@@ -162,7 +162,7 @@ export async function handleHMRUpdate(`
`162`	`162`	`return`
`163`	`163`	`}`
`164`	`164`
`165`		`- const mods = moduleGraph.getModulesByFile(file) \|\| new Set()`
	`165`	`+ const mods = new Set(moduleGraph.getModulesByFile(file))`
`166`	`166`	`if (type === 'create' \|\| type === 'delete') {`
`167`	`167`	`for (const mod of getAffectedGlobModules(file, server)) {`
`168`	`168`	`mods.add(mod)`