From 7c06ef07f835308b1ff2de3df02d201a8dbfb3b6 Mon Sep 17 00:00:00 2001
From: Simon He <57086651+Simon-He95@users.noreply.github.com>
Date: Sun, 23 Jun 2024 22:24:32 +0800
Subject: [PATCH] refactor(optimizer): use early continues (#17551)

---
 packages/vite/src/node/optimizer/optimizer.ts | 19 +++++++++----------
 1 file changed, 9 insertions(+), 10 deletions(-)

diff --git a/packages/vite/src/node/optimizer/optimizer.ts b/packages/vite/src/node/optimizer/optimizer.ts
index 096d0bef2cdd54..8bd9beb95f068f 100644
--- a/packages/vite/src/node/optimizer/optimizer.ts
+++ b/packages/vite/src/node/optimizer/optimizer.ts
@@ -790,17 +790,16 @@ function findInteropMismatches(
   const needsInteropMismatch = []
   for (const dep in discovered) {
     const discoveredDepInfo = discovered[dep]
+    if (discoveredDepInfo.needsInterop === undefined) continue
+
     const depInfo = optimized[dep]
-    if (depInfo) {
-      if (
-        discoveredDepInfo.needsInterop !== undefined &&
-        depInfo.needsInterop !== discoveredDepInfo.needsInterop
-      ) {
-        // This only happens when a discovered dependency has mixed ESM and CJS syntax
-        // and it hasn't been manually added to optimizeDeps.needsInterop
-        needsInteropMismatch.push(dep)
-        debug?.(colors.cyan(`✨ needsInterop mismatch detected for ${dep}`))
-      }
+    if (!depInfo) continue
+
+    if (depInfo.needsInterop !== discoveredDepInfo.needsInterop) {
+      // This only happens when a discovered dependency has mixed ESM and CJS syntax
+      // and it hasn't been manually added to optimizeDeps.needsInterop
+      needsInteropMismatch.push(dep)
+      debug?.(colors.cyan(`✨ needsInterop mismatch detected for ${dep}`))
     }
   }
   return needsInteropMismatch