Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention devTarget option in caveats list #212

Merged
merged 1 commit into from
May 29, 2024
Merged

Mention devTarget option in caveats list #212

merged 1 commit into from
May 29, 2024

Conversation

LoganDark
Copy link
Contributor

No description provided.

Copy link
Member

@ArnaudBarre ArnaudBarre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch!

@ArnaudBarre ArnaudBarre merged commit e078012 into vitejs:main May 29, 2024
1 check passed
@LoganDark LoganDark deleted the patch-1 branch May 29, 2024 12:10
@LoganDark
Copy link
Contributor Author

LoganDark commented May 29, 2024

It's been two years since that was first written, do you think it may be time to update the default to es2022 already? (If es2020 was good in 2022, maybe es2022 is good in 2024?) Having hidden properties visible in the inspector heavily improves the debugging experience, and it took me a couple days to figure out what was transpiling them out, because I couldn't find anything in the Vite or ESBuild documentation. It only occurred to me today to check this plugin, which solved my issue & immediately resulted in this PR.

@ArnaudBarre
Copy link
Member

ArnaudBarre commented May 29, 2024

I need to review what's the current behaviour in core and align with it. There are already multiple issues in core that shows that this is not very clear for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants