Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python 3.6 - 3.7 and django 2. #744

Closed
baseplate-admin opened this issue Apr 18, 2023 · 3 comments
Closed

Drop python 3.6 - 3.7 and django 2. #744

baseplate-admin opened this issue Apr 18, 2023 · 3 comments

Comments

@baseplate-admin
Copy link
Contributor

baseplate-admin commented Apr 18, 2023

Is your feature request related to a problem? Please describe.
I'm always frustrated when i see EOL dependencies are in pyproject.toml

Describe the solution you'd like

  1. Drop every EOL or soon to be EOL python version. ( 3.6 - 3.7 )
  2. Bump django dependency to 3.2 as django 2 is unsupported at this point.

Reasoning :

  1. We can directly support modern django features ( eg : sync_and_async_middlewares )
  2. We can get access to Async ORM ( which is unsupported in django 2.0 )
  3. ...
    I think its a good time to address this as django-ninja is moving to a v1 release
@baseplate-admin baseplate-admin changed the title Drop python 3.6,3.7 and django 2. Drop python 3.6 - 3.7 and django 2. Apr 18, 2023
@baseplate-admin
Copy link
Contributor Author

@vitalik ,

What's your take on this ?

@skokado
Copy link
Contributor

skokado commented May 8, 2023

+1

@vitalik
Copy link
Owner

vitalik commented Jun 5, 2023

personally I do not see reason to drop django 2 - there are just few compatibility wrappers (the async views are already used heavily alot by the projects I'm keeping eye on)

python 3.6 will be dropped with pydantic2

python 3.7 most likely will stay (basically what pydatic supports will be supported by django ninja) - I see in statas some persentage is still using 3.7

@vitalik vitalik closed this as completed Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants