Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hover node #66

Merged
merged 6 commits into from
Jul 18, 2019
Merged

Fix hover node #66

merged 6 commits into from
Jul 18, 2019

Conversation

Tyler-Maclachlan
Copy link
Contributor

@Tyler-Maclachlan Tyler-Maclachlan commented May 24, 2019

Fix node hover breaking when hoverConnectedEdges = false

Fix #64

Fix node hover breaking when hoverConnectedEdges = false
Add a method for editing cluster edge options
setOptions doesn't work for cluster edges? used utils.extend to set options
Don't actually need this
@micahstubbs
Copy link
Member

hi @Tyler-Maclachlan thanks for the contribution! could you run these commands to get the integration tests passing?

Once the tests are green, I'll take a look at this one.

cd visjs-network
yarn
yarn format
git add .
git commit -m "yarn format"
git push

@Tyler-Maclachlan
Copy link
Contributor Author

Hi @micahstubbs, I've run the commands and pushed.

@micahstubbs
Copy link
Member

nice, the tests are green!

I'm going to try and test this out with this example https://jsbin.com/voritexeru/edit?html,js,output

from this issue comment #64 (comment)

does that sound like the best approach to you @Tyler-Maclachlan ?

@Tyler-Maclachlan
Copy link
Contributor Author

Sounds good to me

@Tyler-Maclachlan
Copy link
Contributor Author

hi @micahstubbs,

Any kind of timeline on when this can get merged?

@micahstubbs
Copy link
Member

@Tyler-Maclachlan hopefully soon 😅

Copy link
Member

@micahstubbs micahstubbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution!

@mojoaxel
Copy link

💌 Thanks @Tyler-Maclachlan for your contribution!
This pull-request has been merge into visjs/vis-network#28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting hoverConnectedEdges to false causes node hover to stop working
3 participants