-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix hover node #66
Fix hover node #66
Conversation
Fix node hover breaking when hoverConnectedEdges = false
Add a method for editing cluster edge options
setOptions doesn't work for cluster edges? used utils.extend to set options
Don't actually need this
hi @Tyler-Maclachlan thanks for the contribution! could you run these commands to get the integration tests passing? Once the tests are green, I'll take a look at this one.
|
Hi @micahstubbs, I've run the commands and pushed. |
nice, the tests are green! I'm going to try and test this out with this example https://jsbin.com/voritexeru/edit?html,js,output from this issue comment #64 (comment) does that sound like the best approach to you @Tyler-Maclachlan ? |
Sounds good to me |
hi @micahstubbs, Any kind of timeline on when this can get merged? |
@Tyler-Maclachlan hopefully soon 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the contribution!
💌 Thanks @Tyler-Maclachlan for your contribution! |
Fix node hover breaking when hoverConnectedEdges = false
Fix #64