Correct type of zoomSpeed in 'lib/network/options.js' #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`zoomSpeed` is introduced for configurable manual zoom speed and the type of value is `number` as described in [1]. However, it should be an array of `number` if it is used with Configurator class, or an error is occured in _handleObject(). This update is to correct the type of zoomSpeed and fix visjs-community#37. [1] almende/vis#3657
|
oh, very nice. It's cool to see a solution to #37. that one had me stumped earlier. will have a look at this now 😄 |
|
looks good to me the configuration example loads with no JS errors. when I zoom in and out by scrolling the mousewheel, there are also no JS errors (unlike before) nice work @geminoa 🙌 http://127.0.0.1:8080/examples/other/configuration/
|
micahstubbs
changed the title
This was referenced Jul 26, 2019
|
💌 Thanks @geminoa for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zoomSpeedis introduced for configurable manual zoom speed and thetype of value is
numberas described in [1].However, it should be an array of
numberif it is used withConfigurator class, or an error is occured in _handleObject().
This update is to correct the type of zoomSpeed and fix #37.
[1] almende/vis#3657