Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show all unique values checkbox is outdated/broken #88

Open
alexsb opened this issue Jan 13, 2022 · 4 comments
Open

Show all unique values checkbox is outdated/broken #88

alexsb opened this issue Jan 13, 2022 · 4 comments

Comments

@alexsb
Copy link
Member

alexsb commented Jan 13, 2022

image

I don't think we still use this; it doesn't work.

@Dev-Lan
Copy link
Contributor

Dev-Lan commented Jan 13, 2022

I haven't noticed any issues with this checkbox not working.

During one meeting it seemed like that checkbox wasn't working, but that was because they were already showing all values. See #55. Could that be what happened to you, or is there another issue?

@alexsb
Copy link
Member Author

alexsb commented Jan 13, 2022

Maybe I don't understand what they're doing :)

What are they doing again?

@Dev-Lan
Copy link
Contributor

Dev-Lan commented Jan 13, 2022

If there are more than 5 values in the chart you get the "expand x more values" button below the chart. e.g.

https://user-images.githubusercontent.com/6709955/149383842-3299d6a5-4dd3-4174-b6cf-ea1733aeefbd.png

If you select the show all unique values checkbox it will expand the chart for every column.

I think making the text consistent with those buttons would be better. "expand values for all columns" or "expand all values"?

@alexsb
Copy link
Member Author

alexsb commented Jan 13, 2022

OK, that's what I thought it would do; but the way this does it right now doesn't seem useful. I can just click this directly in the header.

I guess it would be useful if it were to make this list much taller; but then we can't see the table itself anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants