DSAT-106: change 'Revoke All' to 'Revoke File' with accompanying functionality #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanAB
reviewed
Aug 2, 2019
NathanAB
reviewed
Aug 2, 2019
| <div className="RevokeAll-text"> | ||
| If you revoke this file, only you will be able to access it. | ||
| <p /> | ||
| The SDK does not currently support undoing this action. |
There was a problem hiding this comment.
what about just
<p>If you revoke this file, only you will be able to access it.</p>
<p>The SDK does not currently support undoing this action.</p>instead of an empty <p /> ?
NathanAB
reviewed
Aug 2, 2019
| </div> | ||
| <button className="RevokeAll-confirm" onClick={doRevoke}> | ||
| Yes, Revoke This File | ||
| </button> |
There was a problem hiding this comment.
Can we use the Button component instead?
biscoe916
approved these changes
Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revoke Allbutton to top of Policy layout with change to copy asRevoke File