Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strip_prefix unstable #44

Closed
vineetred opened this issue Jul 22, 2020 · 2 comments
Closed

strip_prefix unstable #44

vineetred opened this issue Jul 22, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@vineetred
Copy link
Owner

vineetred commented Jul 22, 2020 •
edited
Loading

Describe the bug
In PR #43 submitted by @Baldomo -- we use a Rust method strip_prefix. This method was deemed unstable. We should stick to safe code

Expected behavior
Ideally, functionality preserving solution that does not use this method.
@vineetred vineetred added the bug Something isn't working label Jul 22, 2020
@Baldomo
Copy link
Contributor

Baldomo commented Jul 22, 2020

I believe the strip_* methods have been stabilised in rust 1.45.0 as per the source code here

@vineetred
Copy link
Owner Author

Crap! I need update Rust then. Closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Baldomo @vineetred