Not all icons are changed

[LPocay]

For some reason not all icons are change, i have ubuntu 18.04, for example, the steam icon look like this:

[PoorPocketsMcNewHold]

That´s normal.
https://github.com/vinceliuice/McMojave-circle/blob/master/src/apps/scalable/steam.svg

[mcdearman]

I've noticed this problem for snap applications like discord and vscode. I've found a work around by putting a .desktop file in /var/lib/snapd/desktop/applications with the path to the pack's icon. But this seems to get undone when snap refreshes.

[PoorPocketsMcNewHold]

I've noticed this problem for snap applications like discord and vscode. I've found a work around by putting a .desktop file in /var/lib/snapd/desktop/applications with the path to the pack's icon. But this seems to get undone when snap refreshes.

The thing is, that this user reported that the Steam icon was unthemed, when actually, it was.
I would recommend you instead, into making a pull request, to modify the README.md to add this work-around for snap applications.

[MahdiBaghbani]

@tinytophy copy all .desktop files you want to be themed from /var/lib/snapd/desktop/applications into ~/.local/share/applications, change ownership of files to your user and start modifying them, linux will always look user local files first and then looks system files, so these .desktop files are selected over the ones provided by snap and won't be affected by a refresh.