-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attribute analysis improvements #7727
Attribute analysis improvements #7727
Conversation
9d185a2
to
035ec6e
Compare
035ec6e
to
c82abe3
Compare
$class_context, | ||
$storage, | ||
$class->attrGroups, | ||
1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we have AttributesAnalyzer::TARGET_DESCRIPTIONS public so that we can use class consts types instead of literals?
Seems pretty fine :) After checking my comments we should be able to merge :) |
Thanks! |
You didn't give me a chance to fix things up after commenting 😛 |
Sorry, I forgot, I was checking at PRs and saw that one ready 😄 |
getAttributes
argument to ensure it's a valid