Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribute analysis improvements #7727

Merged
merged 4 commits into from
Feb 24, 2022

Conversation

AndrolGenhald
Copy link
Collaborator

@AndrolGenhald AndrolGenhald added the release:fix The PR will be included in 'Fixes' section of the release notes label Feb 24, 2022
@AndrolGenhald AndrolGenhald force-pushed the attribute-analysis-improvements branch from 9d185a2 to 035ec6e Compare February 24, 2022 04:30
@AndrolGenhald AndrolGenhald force-pushed the attribute-analysis-improvements branch from 035ec6e to c82abe3 Compare February 24, 2022 04:30
$class_context,
$storage,
$class->attrGroups,
1,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we have AttributesAnalyzer::TARGET_DESCRIPTIONS public so that we can use class consts types instead of literals?

@orklah
Copy link
Collaborator

orklah commented Feb 24, 2022

Seems pretty fine :)

After checking my comments we should be able to merge :)

@orklah orklah merged commit fc2c6ab into vimeo:4.x Feb 24, 2022
@orklah
Copy link
Collaborator

orklah commented Feb 24, 2022

Thanks!

@AndrolGenhald
Copy link
Collaborator Author

You didn't give me a chance to fix things up after commenting 😛
I'll make the improvements mentioned and also do some Psalm 5 improvements in a couple of pull requests sometime in the next few days.

@orklah
Copy link
Collaborator

orklah commented Feb 24, 2022

Sorry, I forgot, I was checking at PRs and saw that one ready 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Need review release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
2 participants