Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuring an absolute URL for Base URL causes renderPage to return null for httpResponse #149

Closed
rjschill87 opened this issue Sep 21, 2021 · 4 comments

Comments

@rjschill87
Copy link

Within analyzeUrl, it appears the URL's origin is removed prior to the comparison against the provided baseUrl:

https://github.com/brillout/vite-plugin-ssr/blob/663886c94cb1fb2b52ac153716bafb65a9e7176e/vite-plugin-ssr/node/renderPage.ts#L1010-L1016

Because of this, it appears hasBaseUrl can never be true, causing { httpResponse: null } to be returned here:

https://github.com/brillout/vite-plugin-ssr/blob/663886c94cb1fb2b52ac153716bafb65a9e7176e/vite-plugin-ssr/node/renderPage.ts#L63-L66

@brillout
Copy link
Member

If the baseUrl contains the origin then yes you're right this will fail. I'll fix this. In the meantime is removing the origin from the base URL an option for you?

@rjschill87
Copy link
Author

@brillout Yup! Still in the testing phases, and do have some workarounds considered, so not production-critical at the moment. Just something noticed during tested that I wanted to bring to attention.

@brillout
Copy link
Member

👍 I'll fix this tomorrow

@brillout
Copy link
Member

Released in v3.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants