-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features should be set before tech initialization #189
Comments
Sorry for the breaking change @eXon! I thought we had avoided that but apparently not. |
Because of this: |
No worry I'll make a new release with this fixed within the next week. |
This change has no effect. Still tons of exception in the console. The reason is that the contructor of the vjs.MediaTechController is called before the constructor of videojs.Youtube. The timer is started because 'timeupdateEvents': false is the default value in video.js. Therefore the settings parameter in youtube.js are ignored. Furthermore to avoid starting the timers the features must be set to true (but as said, this has currently no effect).
Tested with video.js V4.7.3 |
The code to manage manual progress events and time tracking moved into the MediaTechController in video.js 4.7.2. As a result of that, the features object must be set up before invoking
MediaTechController.init()
or time tracking will be turned on. The YouTube tech doesn't need manual time tracking and when it gets disposed, the callback ends up generating errors that show up in the console. It should just be a matter of moving up the assignment of the features object a couple lines. Related to videojs/video.js#1431.The text was updated successfully, but these errors were encountered: