From 36f1cc18ec5f31c23aa713d6cb264a45610b6b89 Mon Sep 17 00:00:00 2001 From: Martin B Date: Mon, 13 Nov 2017 23:42:11 +0000 Subject: [PATCH] Avoid weird title --- src/js/clickable-component.js | 2 +- src/js/menu/menu-item.js | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/js/clickable-component.js b/src/js/clickable-component.js index 200c9a5a2e..aecff06d5a 100644 --- a/src/js/clickable-component.js +++ b/src/js/clickable-component.js @@ -113,7 +113,7 @@ class ClickableComponent extends Component { * - The control text when getting */ controlText(text, el = this.el()) { - if (!text) { + if (text === undefined) { return this.controlText_ || 'Need Text'; } diff --git a/src/js/menu/menu-item.js b/src/js/menu/menu-item.js index 763001da2c..21c873665c 100644 --- a/src/js/menu/menu-item.js +++ b/src/js/menu/menu-item.js @@ -97,8 +97,7 @@ class MenuItem extends ClickableComponent { this.removeClass('vjs-selected'); this.el_.setAttribute('aria-checked', 'false'); // Indicate un-selected state to screen reader - // Note that a space clears out the selected state text - this.controlText(' '); + this.controlText(''); } } }