Allow viewing in-band metadata tracks from shimmed texttracklist #2272
Conversation
| @@ -61,6 +61,9 @@ vjs.Html5 = vjs.MediaTechController.extend({ | |||
|
|
|||
| if (this['featuresNativeTextTracks']) { | |||
| this.on('loadstart', vjs.bind(this, this.hideCaptions)); | |||
| } else { | |||
| // allow us to view the in-band metadata tracks from our shimmed TextTrackList | |||
| this.on('loadedmetadata', vjs.bind(this, this.addInBandMetadataTracks)); | |||
There was a problem hiding this comment.
I'm not sure that inband tracks will show up by loadedmetadata. Did you find this in the spec or discover it experimentally?
There was a problem hiding this comment.
Though, this reminds me. I probably need to remove the old ones from the list on source change.
There was a problem hiding this comment.
An in-band metadata track might not be evident until a decent amount of buffering has occurred. If there were a way to make the track registration a bit more robust for that case, that would be great.
There was a problem hiding this comment.
I'll take a look whether the addtrack event fires for it. Might listen to both or something.
|
This should handle multiple in-band metadata tracks better and should be able to clear them out properly between video loads. |
| track, | ||
| i = 0; | ||
|
|
||
| for (i = 0; i < tracks.length; i++) { |
There was a problem hiding this comment.
This shouldn't be necessary unless addtrack fired twice, right?
There was a problem hiding this comment.
Yeah, I'm not certain it'll be necessarily useful. Even if you re-apply the same video you get a new track.
This was kind of left-over from when I had the removal of tracks in the same method as additions and so far I left it for "extra security" but I'm not certain it actually buys us much.
|
We should have a test for this. |
|
I'll try and come up with some tests. |
gkatsev
changed the title
|
This will become obsolete as part of the work to fix #2367. I'm using this general framework for that fix anyway. Given that we've decided not to include it in stable, I'm going to close this. |
Fixed #2266.