fix(error): chromium reset mediaError when the poster is invalid #8410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When both the media URL and the poster return a response other than 200. The media error is overwritten by an empty error, leaving the player in an inconsistent state. - add a condition to `handleTechError_` to ensure that the `error` is truthy - add a test case Fixes videojs#8409
Codecov Report
@@ Coverage Diff @@
## main #8410 +/- ##
=======================================
Coverage 82.68% 82.68%
=======================================
Files 113 113
Lines 7578 7579 +1
Branches 1821 1822 +1
=======================================
+ Hits 6266 6267 +1
Misses 1312 1312
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mister-ben
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8409, when both the media URL and the poster return a response other than 200. The media error is overwritten by an empty error, leaving the player in an inconsistent state.
Screencast.from.20.08.23.18.35.52.webm
Specific Changes proposed
handleTechError_to ensure that theerroris truthyRequirements Checklist