Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Followup to #8356. The issue with older Safari with
document.styleSheets
is a little different than thought. The problem is that Safari doesn't necessarily return rules verbatim, so a text comparison wasn't working. A rule with a shorthand property likebackground: white;
is returned asbackground-color: white;
.Specific Changes proposed
Changes the test to use a rule that won't be changed.
Revert skipping the test on Safari from #8356 as we can make that test work after all.
Change copyStyleSheets to use
styleSheet.media.mediaText
when setting media. On old Safari this has to be a string, other browsers allow the MediaList object to be set.Test ran on browserstack passed here:
https://github.com/mister-ben/video.js/actions/runs/5600546784/jobs/10243092934