fix(tests): Skip a test on old Safari #8356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amtins
approved these changes
Jul 14, 2023
There was a problem hiding this comment.
LGTM!
@mister-ben would there be a way to run all the tests when a PR has reached its review quota? This would make it possible to see that some tests don't pass before reaching main.
|
@amtins agree we need to have PR tests running on browserstack |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Safari versions less than 14 have a broken
document.styleSheets- not all style elements are included, which breaks a recent test. We're currently running tests on Brpwserstack on Safari 12 on main.Specific Changes proposed
Since we use the
copyStyleSheetsfunction only in browsers that support documentPictureInPicture, this simply skips the test on Safari < 14. Should Safari implement documentPictureInPicture in a future update this isn't a concern asdocument.styleSheetsbehaves properly on 14+.Requirements Checklist