fix: mark global/window/document as external globals #7438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
built off of the work in videojs/videojs-generate-rollup-config#40
Codecov Report
@@ Coverage Diff @@
## main #7438 +/- ##
=======================================
Coverage 79.72% 79.72%
=======================================
Files 116 116
Lines 7296 7296
Branches 1754 1754
=======================================
Hits 5817 5817
Misses 1479 1479 Continue to review full report at Codecov.
|
brandonocasey
approved these changes
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
built off of the work in videojs/videojs-generate-rollup-config#40