Player class missing attribute exports

[iamjem]

There are several important API methods not exported on Player class instances in the minified version of the source code. I can't imagine this is intentional?

For example, all of these will return undefined when accessed on a player instance returned from the videojs constructor:

playerInstance.remainingTime
playerInstance.supportsFullScreen
playerInstance.enterFullWindow
playerInstance.exitFullWindow
playerInstance.selectSource
playerInstance.preload
playerInstance.ended

I can see maybe hiding some of the fullscreen methods, but ultimately I think virtually every method on the player instance should be public.

[heff]

You're right on these.
ended() is now supported.
selectSource I'd be interested to know what usecase there was behind needing access to it.
Everything else could absolutely be exposed, we've just waited for requests in order to keep the file size as small as possible. Would you be interested in making a pull request for it?

[mmcc]

A lot of these are exported at this point (fullscreen methods and ended). @iamjem - Do you still see a need for the others?

[iamjem]

Should be good now, I've just run into some headaches before trying to make some quick one-off custom components for projects where there wasn't access to certain parts of the API.

[heff]

@mmcc it's not the fullscreen methods there, it's the fullWindow methods. Basically everything in that list still needs to be exported except ended and selecSource (unless we find a good use case).

I labeled this as easy, hoping someone will pick it up and do a PR for it. :)

@iamjem, in the next major version we're going to switch from a whitelist approach to a blacklist for variable mangling, so there should be less issue around this.

[dcharbonnier]

selectSource can be used by some plugins, example this very dirty code : https://github.com/theonion/videojs-vast-plugin/blob/master/videojs.vast.js#L213
You want me to open a ticket for that ?