fix: encrypted content goes black in IE/Edge when video element focused #6318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkatsev
reviewed
Nov 15, 2019
package.json
Outdated
| @@ -153,6 +153,7 @@ | |||
| }, | |||
| "vjsstandard": { | |||
| "ignore": [ | |||
| "build", | |||
There was a problem hiding this comment.
What type of errors were you seeing? I don't have any issues running the linter locally.
There was a problem hiding this comment.
My local build/ directory was somehow outdated. This is not needed so I removed it.
src/js/big-play-button.js
Outdated
| @@ -46,8 +47,16 @@ class BigPlayButton extends Button { | |||
|
|
|||
| // exit early if clicked via the mouse | |||
| if (this.mouseused_ && event.clientX && event.clientY) { | |||
| const sourceIsEncrypted = this.player_.usingPlugin('eme') && | |||
| this.player_.eme.sessions && | |||
There was a problem hiding this comment.
should probably either line up or be indented once
There was a problem hiding this comment.
Yeah it was lined up in my editor but the indentation didn't carry over correctly for some reason. I'll figure it out.
gkatsev
approved these changes
Nov 19, 2019
|
Looks like any programmatic call to focus causes the video element to turn black. |
Merged
7 tasks
This was referenced Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6270. This appears to be caused by an unreported browser bug. It also reproduces with shaka player if you call
document.querySelector('video').focus()while playing back DRM content. For now, the only solution is simply to avoid callingvideoEl.focus()in IE/Edge for DRM. This unfortunately may prevent hotkeys from working correctly in IE/Edge.Specific Changes proposed
Modify the conditions under which we call
this.player_.tech(true).focus()when the big play button is clicked.