Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Create a base time display class, and use it #4633

Merged
merged 1 commit into from
Oct 2, 2017
Merged

refactor: Create a base time display class, and use it #4633

merged 1 commit into from
Oct 2, 2017

Conversation

brandonocasey
Copy link
Contributor

Description

Refactor the Time displays so that they use the same base class, as they are nearly all the same.

Specific Changes proposed

Create a TimeDisplay class and use that class in DurationDisplay, RemainingTimeDisplay, or CurrentTimeDisplay

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)

@brandonocasey brandonocasey mentioned this pull request Sep 27, 2017
Merged
3 tasks
misteroneill
misteroneill approved these changes Sep 29, 2017
View reviewed changes
Copy link
Member

@misteroneill misteroneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good idea to me.

@brandonocasey brandonocasey merged commit fa6f884 into master Oct 2, 2017
@gkatsev gkatsev deleted the refactor/base-time-displays branch March 19, 2018 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misteroneill misteroneill misteroneill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brandonocasey @misteroneill