Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add tests for obj.assign util #4014

Merged
merged 1 commit into from
Feb 2, 2017
Merged

test: add tests for obj.assign util #4014

merged 1 commit into from
Feb 2, 2017

Conversation

brandonocasey
Copy link
Contributor

Description

A question was brought up about Obj.assigns behavior, I wrote some unit tests to clear things up.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
  • Reviewed by Two Core Contributors

@brandonocasey brandonocasey mentioned this pull request Feb 1, 2017
Merged
6 tasks
@gkatsev
Copy link
Member

gkatsev commented Feb 1, 2017

This will be test: rather than chore:

@brandonocasey
Copy link
Contributor Author

good call @gkatsev, will update the commit and the title as not to confuse myself or anyone else that goes to merge this

@brandonocasey brandonocasey changed the title chore: add tests for obj.assign util test: add tests for obj.assign util Feb 1, 2017
misteroneill
misteroneill approved these changes Feb 2, 2017
View reviewed changes
Copy link
Member

@misteroneill misteroneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could've sworn I wrote tests for this, but maybe not. 😆

@brandonocasey brandonocasey merged commit fcb5aa8 into master Feb 2, 2017
@brandonocasey brandonocasey deleted the chore/obj-assign-tests branch February 2, 2017 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misteroneill misteroneill misteroneill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brandonocasey @gkatsev @misteroneill