Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tr.json #3989

Merged
merged 3 commits into from
Jan 27, 2017
Merged

Update tr.json #3989

merged 3 commits into from
Jan 27, 2017

Conversation

altaywtf
Copy link
Contributor

Description

Adds missing translate strings for Turkish.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you run grunt check-translations to update the translations-needed doc and add it to the PR?
https://github.com/videojs/video.js/blob/master/docs/translations-needed.md

LGTM, otherwise.

@@ -15,20 +16,62 @@
"Playback Rate": "Oynatma Hızı",
"Subtitles": "Altyazı",
"subtitles off": "Altyazı Kapalı",
"Captions": "Ek Açıklamalar",
"captions off": "Ek Açıklamalar Kapalı",
"Captions": "Altyazı",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess there's not much difference between subtitles and captions in turkish?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly.

@altaywtf
Copy link
Contributor Author

Thanks @gkatsev 👍

@gkatsev gkatsev merged commit 37a6811 into videojs:master Jan 27, 2017
@gkatsev
Copy link
Member

gkatsev commented Jan 27, 2017

Thanks @altayaydemir!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants