Cache currentTime and buffered from Flash #3705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling into the SWF too often is expensive. Current time and buffered don't actually change that often but it's very common to call them a couple times in the handling of a single event. Cache their return values for 100ms so the performance penalty of going through ExternalInterface is limited.
| return result.cache_; | ||
| }; | ||
|
|
||
| result.lastCheckTime_ = -Infinity; |
There was a problem hiding this comment.
When you want to be absolutely certain! 😆
| * @return {Function} a new function that returns cached results if | ||
| * invoked multiple times within the cache duration | ||
| */ | ||
| export default function timeExpiringCache(getter, cacheDuration) { |
There was a problem hiding this comment.
Since both uses of this function pass 100 here, I wonder if having a default (i.e. cacheDuration = 100) makes sense?
gkatsev
added a commit
that referenced
this pull request
Nov 14, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Calling into the SWF too often is expensive. Current time and buffered don't actually change that often but it's very common to call them a couple times in the handling of a single event. Cache their return values for 100ms so the performance penalty of going through ExternalInterface is limited.
Specific Changes proposed
Cache return values from
currentTimeandbufferedfor 100ms in the Flash tech.Requirements Checklist