Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player not being responsive #2146

Closed
dschinkel opened this issue May 13, 2015 · 3 comments
Closed

Player not being responsive #2146

dschinkel opened this issue May 13, 2015 · 3 comments

Comments

@dschinkel
Copy link

Here's my code, the player is not responsive meaning if I shrink the browser, it's not resizing inside my div appropriately. My div is cutting off the player which has a fixed height and width. I tried taking off the fixed height and width in the controls but same deal, same results.

as you can see I'm also using bootstrap

<div class="col-sm-9 well">
    <div class="row">
        <div class="col-sm-12">
            <div class="media">
                <p><h1><%= string.Format( "#{0} - {1}", ViewData.Model.Number, ViewData.Model.Name ) %></h1></p>
                <div class="media-body">
                    <p>
                        <video id="<%=ViewData.Model.Name%>" class="video-js vjs-default-skin"
                            controls preload="auto" width="1280" height="720"
                            poster="../../images/CastThumb_Large.png"
                            data-setup='{"autoplay": false, "preload": "auto"}'>

                            <source src=<% = ViewData.Model.FileName %> type='video/mp4' />
                        </video> 
                    </p>
                </div>
            </div>
        </div>
    </div>
</div>

I have even taken the step to trim all markup and just included the video player in the page alone inside a div. I know that this player was definitely being responsive in the past but seems like now, it's just not working in that respect even when I put it alone in a page!

@dschinkel
Copy link
Author

Resolved. But I could have sworn this control was being responsive before this..maybe not.

I just added that padding and height per the article http://alistapart.com/article/creating-intrinsic-ratios-for-video/ to the containing div and it's working now, it's responsive in size.

@dschinkel
Copy link
Author

@heff
Copy link
Member

heff commented May 13, 2015

We're just about to merge #1952, which which will make this possible by default in version 5.0.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants