Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapters button should have a different Icon from subtitles #1954

Closed
OwenEdwards opened this issue Mar 17, 2015 · 4 comments
Closed

Chapters button should have a different Icon from subtitles #1954

OwenEdwards opened this issue Mar 17, 2015 · 4 comments

Comments

@OwenEdwards
Copy link
Member

If a 'chapters' track is present or added, an extra ControlBar item is added to select between the chapters. The Chapters icon is identical to the Subtitles icon, which is visually confusing (especially since Subtitles are more similar to Captions, which have a totally different icon!).

I suggest using one of the 'bookmark' type icons from the Icomoon font; unfortunately there isn't a nice 'book with bookmark' type icon in their free font. And I'm not clear how to add it, otherwise I'd do a PR!

@heff
Copy link
Member

heff commented Mar 18, 2015

Thanks! Confirming this is an issue. @mmcc might be able to speak to the right font icon. We're switching fonts in 5.0 (I think).

@mmcc
Copy link
Member

mmcc commented Mar 18, 2015

This was an oversight of sorts. When I initially made the font chapters weren't working yet, so an icon didn't make it into the set. I'll definitely make sure a bookmark makes it into the 5.0 font.

@OwenEdwards
Copy link
Member Author

Sure, totally understand. Just wanted to make sure this was on your radar, moving forward. It came up as I'm looking at support for other types of text track. Do you have test cases for chapters track(s)? Do many people even use them? It seems like @gkatsev is fielding the majority of the work on TextTracks, but this crosses into a UI/UX issue.

@mmcc
Copy link
Member

mmcc commented Apr 28, 2015

This should be fixed in master that #1999 is pulled in (new icons and the chapters button is indeed different).

@mmcc mmcc closed this as completed Apr 28, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants