Dev Vs Prod

[tomul]

Hi,
I'm trying to use videojs 4.7 with support for youtube (https://github.com/eXon/videojs-youtube). While using the development version of videojs (video.dev.js), it works, but if i use the minified (video.js) version it breaks in IE10 (windows 7) for a youtube video, when clicking the fullscreen button. The tech has the required methods, but supportsFullScreen() is never called. Instead it just throws an error: Object doesn't support property or method 'Ea'. If i add a method `videojs.Youtube.prototype.Ea= function() {
return false;
};`` it works, but i don't think this should be the fix. Using videojs 4.8, with the proper modifications for videojs-youtube, doesn't fix it, the same error is shown.
Please check: http://jsbin.com/waliv/1/edit

Thank you

[gkatsev]

Looks like a minification issue with videojs.

[heff]

@tomul I believe @gkatsev fixed this in 4.8.4. Would you be able to check?

[tomul]

Thank you for the update. Just checked it now with 4.8.5, and it's not fixed, IE 10 error: Object doesn't support property or method 'Da'.

[gkatsev]

I'm actually getting an error from videojs-youtube now. Looks like the used the features feature on the tech which doesn't exist anymore.

[gkatsev]

Oh, never mind, most-up-to-date version of videojs-youtube supports it.

[gkatsev]

Grabbing vjs 4.8.5 and the latest videojs-youtube works for me: http://jsbin.com/bahahododewi/1/edit

[gkatsev]

@tomul can you retest with the latest versions of videojs and the youtube plugin? Thanks!

[tomul]

@gkatsev I tested with your example (http://jsbin.com/bahahododewi/1/edit), using the Windows 7 image from Modern.ie, and i'm still getting the same error, when trying to go fullscreen.

[gkatsev]

What version of IE?

[tomul]

IE 10, sorry for not mentioning it in the other comment.

[mmcc]

Confirmed with IE 10 + Videojs 4.9 and the src from master of the YT tech.

[psyked]

To weigh in on this, I've had a similar issue with the showTextTrack API call, and it looks like it's down to the aggressive mangling of the minified version of the code. It works in Dev, but not using the provided minified version.

[gkatsev]

showTextTrack however is meant to be a private method.

[rodincave]

Hi, we have a similar issue with our videojs tech plugin ( it's a plugin to integrate peer-to-peer video streaming, you can see it working here: http://www.streamroot.io/demo?url=http%3A%2F%2Fakamai.streamroot.edgesuite.net%2Fvodorigin%2Ftos.mp4%2Fmanifest.mpd )

The issue is that you can't really create a Tech with the videoJS plugin API, and so all the other techs seem to only work with the unminified dev version of videojs, and crash with the minified version.

I am not sure the issue is exactly the same, or if I should open another issue concerning custom techs creation and videojs minifying ?

[heff]

@rodincave we'll be addressing this to some degree in 5.0, by not mangling object properties. Otherwise we would need to get more specific about which APIs are needed and not available in the minified version.

[rodincave]

Thanks, I'll have to recheck the error to confirm this, but from our code I would say that what we are missing is the access to MediaTechController.

you can take a look at our tech provider here:
http://files.streamroot.io/release/1.0/wrappers/videojs/streamroot.wrapper.js

[norlin]

Hi, have the same issue with minified videojs version.

Object doesn't support property or method 'Ea'

Referencing to the this.tech.supportsFullScreen() in player.js (uncompressed code)

[mmcc]

Now that we've moved away from Closure Compiler (#1586) this shouldn't be an issue in Master.