Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically change RTMP source #1399

Closed
bmeine opened this issue Aug 5, 2014 · 10 comments
Closed

Dynamically change RTMP source #1399

bmeine opened this issue Aug 5, 2014 · 10 comments

Comments

@bmeine
Copy link

bmeine commented Aug 5, 2014

I'd like to be able to dynamically change the RTMP src of the player so I can implement a rough adaptive bitrate solution over RTMP. The problem is when I try to set the src it freezes. Below is a jsfiddle with a simplified version just using a timer to change the src. I actually tried a few different suggestions I'd found, but none worked. This seemed like the most likely solution, but I could be completely wrong...and probably am :)

http://jsfiddle.net/Gkzqw/2/

Any idea why this is happening?

@mmcc
Copy link
Member

mmcc commented Aug 8, 2014

We've had similar reports, so I don't think this is wrong. My guess is this is similar to #834. Want to take a look and, if it is, throw your two cents on the SWF issue that was opened?

@mmcc mmcc added bug labels Aug 8, 2014
@legnaleurc
Copy link

I have same issue here. However it works if I use the uncompressed video.js.

@mmcc
Copy link
Member

mmcc commented Aug 23, 2014

@legnaleurc Mind posting an example somewhere? This is working for you with the dev version?

@legnaleurc
Copy link

Compressed version (video.js):
http://jsfiddle.net/legnaleurc/m7991mkv/
stops in player.src(): this.ge is not a function

Uncompressed version (video.dev.js):
http://jsfiddle.net/legnaleurc/a33cf7zt/
working

Library is 4.7.3, downloaded from your website.

@bmeine
Copy link
Author

bmeine commented Aug 25, 2014

Good find! I'd actually run into a similar problem (compressed vs uncompressed) with another JS library a while back and didn't think to try that with this library.

@mmcc
Copy link
Member

mmcc commented Aug 27, 2014

@legnaleurc very nice. Thanks, this is really helpful! @bmeine I assume this gets you running in the meantime, but we'll debug what's going on here. @heff: any ideas off the top of your head?

@bmeine
Copy link
Author

bmeine commented Aug 27, 2014

Yep, I'll move forward with the uncompressed version right now.

@mmcc
Copy link
Member

mmcc commented Sep 2, 2014

Great, that's good to hear you won't be blocked while we figure this one out.

@jsmits21
Copy link

Hey guys, some insight into the problem over on the ticket I made:

#1612

@gkatsev
Copy link
Member

gkatsev commented Jul 25, 2016

In videojs 5, we're no longer doing the super compression, so, it should be better.
Also, if this is still an issue, a PR would be welcome but it's unlikely that any of the core members will work on it due to the decline of Flash in recent years. Because of this, I'm going to close this issue but we would still be open for bug fix PRs.

@gkatsev gkatsev closed this as completed Jul 25, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants