Touch events on Buttons

[jonzeper]

In latest Chrome on Android 4.3, we're unable to receive click events on Buttons, because touchmove events are thrown for all but the slightest of taps. This block in button.js prevents click events from being thrown if any touchmove events are thrown after a touchstart.
https://github.com/videojs/video.js/blob/master/src/js/button.js#L18-L33

Does anyone know if this code is still needed? Or can we safely remove it..

Here's the commit which introduced this block:
9555b80

[gkatsev]

Yes, it is still needed, however, perhaps it should be refactors to allow some wiggle (pun intended) room.

[marvinli]

We'd love to give it a shot. Can you elaborate on what we should do? Should we do some distance based threshold for the touchmove?

[gkatsev]

Yeah, that's basically it. Rather than cancelling on all touchmoves, only cancel on touchmoves that are within a distance threshold.

[marvinli]

Okay, we'll work on this tomorrow. Cheers!

[heff]

Fixed by #1111