Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to standard minified file naming conventions #1013

Closed
3 tasks done
heff opened this issue Feb 14, 2014 · 3 comments
Closed
3 tasks done

Switch to standard minified file naming conventions #1013

heff opened this issue Feb 14, 2014 · 3 comments

Comments

@heff
Copy link
Member

heff commented Feb 14, 2014

For 5.0 we should use video.js and video.min.js instead of video.dev.js and video.js. The original reason for using the minified version as the main lib is all the variable mangling that closure compiler does to get the size so small. If you built something with private but available functions using the unminified version, it would break on you when you switched to the minified version.

We should find a better way to communicate that issue and stick with the standard naming. And also we may do less var mangling in 5.0.

To finish

  • Feature implemented
  • Docs/guides updated
  • Examples updated (including JSbins, fiddles, etc.)
@dconnolly
Copy link
Contributor

Grabbing this. 👊 EDIT: nevermind, already resolved.

@heff
Copy link
Member Author

heff commented Apr 28, 2015

There's probably some guides and examples that need to be updated to use video.min.js instead of video.js.

dmlap added a commit to dmlap/video.js that referenced this issue Apr 29, 2015
Change the docs to point to the new minified name for video.js. For videojs#1013.
@heff
Copy link
Member Author

heff commented Apr 29, 2015

Closed by #2087!

@heff heff closed this as completed Apr 29, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants